Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Feature/COR-1610 about page improvements #4803

Merged

Conversation

Jorrik-Klijnsma-Work
Copy link
Contributor

Summary

features changed:

  • Divided the content into two columns on the page.
  • Extended the Sanity schema to accept two description fields: one for the left column and one for the right column.
  • Added a new field in Sanity. where a image can be uploaded to the about page
  • Added a timeline image to the left column with interactive functionality, similar to the graphs on the dashboard. When clicked, the timeline will appear full screen, darkening the dashboard in the background.
  • Added the ability to upload separate versions for both the NL and EN languages in Sanity.
  • Included a caption for the figure/image, sourced from Sanity.

Screenshots

Before

Toggle before screenshots Screenshot 2023-06-28 at 17 15 26 Screenshot 2023-06-28 at 17 15 45

After

Toggle after screenshots Screenshot 2023-06-28 at 17 13 41 Screenshot 2023-06-28 at 17 13 49 Screenshot 2023-06-28 at 17 14 51 Screenshot 2023-06-28 at 17 15 39

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Copy link
Contributor

@VWSCoronaDashboard26 VWSCoronaDashboard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should have a look at the alignment of the content with the header and footer of the page, as the content seems to be a bit wider. This comment can be ignored if it was designed as such, but it threw me off a bit.

packages/app/src/components/cms/content-image.tsx Outdated Show resolved Hide resolved
packages/app/src/pages/over.tsx Show resolved Hide resolved
packages/app/src/pages/over.tsx Outdated Show resolved Hide resolved
packages/app/src/pages/over.tsx Outdated Show resolved Hide resolved
packages/app/src/pages/over.tsx Outdated Show resolved Hide resolved
packages/app/src/pages/over.tsx Outdated Show resolved Hide resolved
packages/cms/src/schemas/documents/pages/about.ts Outdated Show resolved Hide resolved
packages/cms/src/schemas/locale/image.ts Outdated Show resolved Hide resolved
packages/app/src/pages/over.tsx Outdated Show resolved Hide resolved
packages/app/src/pages/over.tsx Show resolved Hide resolved
packages/cms/src/schemas/locale/image.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Amber-Taal-Work Amber-Taal-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check the space between the columns, margins and font sizes with the Design?

APW26
APW26 previously approved these changes Jun 30, 2023
Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment and screenshot

packages/cms/src/schemas/locale/image.ts Outdated Show resolved Hide resolved
packages/cms/src/schemas/locale/image.ts Outdated Show resolved Hide resolved
# Conflicts:
#	packages/app/src/components/fullscreen-chart-tile.tsx
APW26
APW26 previously approved these changes Jul 3, 2023
APW26
APW26 previously approved these changes Jul 3, 2023
@APW26 APW26 requested review from VWSCoronaDashboard30 and removed request for VWSCoronaDashboard26 July 3, 2023 11:51
APW26
APW26 previously approved these changes Jul 3, 2023
APW26
APW26 previously approved these changes Jul 3, 2023
@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work changed the title Feature/cor 1610 about page improvements Feature/COR-1610 about page improvements Jul 4, 2023
Copy link
Contributor

@Amber-Taal-Work Amber-Taal-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work merged commit ccd398c into develop Jul 5, 2023
@Jorrik-Klijnsma-Work Jorrik-Klijnsma-Work deleted the feature/COR-1610-about-page-improvements branch July 5, 2023 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants