-
Notifications
You must be signed in to change notification settings - Fork 45
Feature/COR-1610 about page improvements #4803
Feature/COR-1610 about page improvements #4803
Conversation
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should have a look at the alignment of the content with the header and footer of the page, as the content seems to be a bit wider. This comment can be ignored if it was designed as such, but it threw me off a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check the space between the columns, margins and font sizes with the Design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment and screenshot
# Conflicts: # packages/app/src/components/fullscreen-chart-tile.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Summary
features changed:
Screenshots
Before
Toggle before screenshots
After
Toggle after screenshots